Add Faker::Music::Opera #1619
Merged
Add Faker::Music::Opera #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Adsidera please add documentation link to unreleased_README file so that we can update to README after release. |
vbrazo
reviewed
Jun 4, 2019
doc/music/opera.md
Outdated
| @@ -0,0 +1,8 @@ | |||
| # Faker::Music::Opera | |||
There was a problem hiding this comment.
this file should be inside the doc/unreleased folder
There was a problem hiding this comment.
if we add it to the doc folder directly, people will think it's in the current version and it's not yet
There was a problem hiding this comment.
@vbrazo ok! Btw, can all these informations and guidelines be added to the Contributing page as well? They are yet missing from that page
vbrazo
approved these changes
Jun 6, 2019
sanikkenway
added a commit
to sanikkenway/faker
that referenced
this pull request
Jun 6, 2019
Add Faker::Music::Opera (faker-ruby#1619)
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* added tests and corrected yaml * corrected test * fixed missing magic comment and missing spaces * added dashed array in yml and doc * moved opera.md to doc/music/opera.md and added link to it in ureleased_README * moved test_faker_opera to faker/music directory * corrected path to test_helper in test_faker_opera.rb * moved opera.md to doc unreleased * restarted pr
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* added tests and corrected yaml * corrected test * fixed missing magic comment and missing spaces * added dashed array in yml and doc * moved opera.md to doc/music/opera.md and added link to it in ureleased_README * moved test_faker_opera to faker/music directory * corrected path to test_helper in test_faker_opera.rb * moved opera.md to doc unreleased * restarted pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundle exec rakeopera.ymlin `locales/en'Now Faker can generate a title of an opera by Rossini, Donizetti, Verdi or Bellini