Fix name_with_middle in Chinese locales #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chinese names don't really have middle names. Chinese also doesn't really use spaces. I made name_with_middle just return name and got rid of the spaces.
vbrazo
reviewed
Mar 10, 2019
|
Why wouldn’t someone using the Chinese locales just ignore this method? |
|
Hi!!
In my head, I figured that people would want to write language-independent
code/tests and then switch the locales out to test their code in different
locales.
Do y'all think this is a valid use case? If not I can change the PR to just
delete the data.
On Mon, Mar 11, 2019, 09:17 Benjamin Curtis ***@***.***> wrote:
Why wouldn’t someone using the Chinese locales just ignore this method?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1567 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABVGCMWWxxGQM3LOHaE6q26OVtwZvyoks5vVldRgaJpZM4bnbo7>
.
--
…-Rocky
|
|
I think the PR is fine as is. Thanks for contributing! |
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
Chinese names don't really have middle names. Chinese also doesn't really use spaces. I made name_with_middle just return name and got rid of the spaces.
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
Chinese names don't really have middle names. Chinese also doesn't really use spaces. I made name_with_middle just return name and got rid of the spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi thanks for faker! It's been helpful in our app.
Chinese names don't really have middle names. Chinese also doesn't
really use spaces. I made name_with_middle just return name and got rid
of the spaces.
I thought this was important to fix because Chinese doesn't use spaces and having/not having spaces affects word wrapping. Therefore it is important not to have spaces in Chinese.