Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maroon 5 and Paramore to music #1447

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Add Maroon 5 and Paramore to music #1447

merged 1 commit into from
Oct 26, 2018

Conversation

Jcambass
Copy link
Contributor

This adds the bands Paramore and Maroon 5 to the music locale.
Some of their more prominent albums were also added.

Source of album names:

<<~FANDOM
  Looking forward to see paramore and maroon 5 in my generated test data <3
FANDOM

This adds the bands `Paramore` and `Maroon 5` to the `music` locale.
Some of their more prominent albums were also added.

Source of album names:
* https://en.wikipedia.org/wiki/Paramore_discography
* https://en.wikipedia.org/wiki/Maroon_5_discography

```ruby
<<~FANDOM
  Looking forward to see paramore and maroon 5 in my generated test data
  <3
FANDOM
```
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vbrazo vbrazo merged commit c18a9f1 into faker-ruby:master Oct 26, 2018
@Jcambass Jcambass deleted the add_maroon_5_and_paramore branch May 9, 2019 11:50
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
This adds the bands `Paramore` and `Maroon 5` to the `music` locale.
Some of their more prominent albums were also added.

Source of album names:
* https://en.wikipedia.org/wiki/Paramore_discography
* https://en.wikipedia.org/wiki/Maroon_5_discography

```ruby
<<~FANDOM
  Looking forward to see paramore and maroon 5 in my generated test data
  <3
FANDOM
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants