Add Faker::Job pt-BR locales #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
approved these changes
Oct 24, 2018
lib/locales/pt-BR.yml
Outdated
| position: ["Supervisor", "Associado", "Executivo", "Contato", "Oficial", "Gerente", "Engenheiro", "Especialista", "Diretor", "Coordenador", "Administrador", "Arquiteto", "Analista", "Designer", "Planejador", "Orquestrador", "Técnico", "Desenvolvedor", "Fabricante", "Consultor", "Assistente", "Facilitador", "Agente", "Representante", "Estrategista"] | ||
| key_skills: ["Trabalho em equipe", "Comunicação", "Resolução de problemas", "Liderança", "Organização", "Trabalhar sobre pressão", "Confiança", "Auto motivado", "Habilidades de networking", "Proatividade", "Aprendizado rápido", "Experiência com tecnologia"] | ||
| employment_type: ["Integral", "Meio período", "Temporário", "Contrato", "Estágio", "Comissão"] | ||
| education_level: ["Associate", "Bacharelado", "Mestrado", "Doutorado"] |
There was a problem hiding this comment.
Associate? Shouldn't this one be associado?
There was a problem hiding this comment.
Associate? Shouldn't this one be
associado?
It would be if the translation was literal, but this is about types of degrees. I left it as Associate because associate degrees don't exist in Brazil, but someone could acquire one if they studied abroad. The other option was removing it, but I thought the former a better option. Should I just remove it?
There was a problem hiding this comment.
and I just did. Let's get this one merged. Thanks 👍
vbrazo
changed the title
vbrazo
changed the title
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* add missing pt-BR locale for job class * add job tests for pt-BR locale * Update pt-BR.yml * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I noticed there was no pt-BR locale/translation for the job class, so I made my own. I also added the necessary locale tests. I ran the tests and also tested the gem myself to see the results and everything seems fine. Let me know if something looks wrong!