Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::Movies::Ghostbusters #1400

Merged
merged 13 commits into from
Oct 12, 2018
Merged

Add Faker::Movies::Ghostbusters #1400

merged 13 commits into from
Oct 12, 2018

Conversation

eddorre
Copy link
Contributor

@eddorre eddorre commented Oct 11, 2018

Listed as one of the most quotable movies of all time. Who doesn't want a Fake person named Dr. Egon Spengler?

Adds Ghostbusters actors, characters and quotes.

vbrazo
vbrazo reviewed Oct 12, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 👍

Could you wrap this new object in a module like Faker::Movies::Ghostbusters?

You also need to update our README.md.

doc/ghostbusters.md Outdated

```ruby

Faker::DumbAndDumber.actor #=> "Bill Murray"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy and 🍝

@vbrazo vbrazo changed the title Added Ghostbusters faker file including tests and doc Add Faker::Movies::Ghostbusters Oct 12, 2018
vbrazo
vbrazo approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vbrazo vbrazo merged commit b4d1579 into faker-ruby:master Oct 12, 2018
@eddorre eddorre deleted the add-ghostbusters branch October 12, 2018 03:45
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@eddorre @vbrazo
Add Faker::Movies::Ghostbusters (faker-ruby#1400)
2774c25 
* Added Ghostbusters faker file including tests and doc.

* Added missing comma in Ghostbusters translation file.

* Add base Faker::Movies module.

* Renamed test file. Test file now incorporates wrapping Ghostbusters class under Movies module.

* Moved ghostbusters file under movies directory and class is now scoped to a movies module.

* Fixed copy pasta errors.

* Added movies to require statements.

* Added Movies to subclasses array.

* Updated README to incorporate Ghostbusters.

* Update CHANGELOG.md

* Update ghostbusters.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@eddorre eddorre

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddorre @vbrazo