Fix female_first_name and male_first_name #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add first_name method to bg locale * Add male_first_name and female_first_name methods to en-MS locale * Fix female_first_name and male_first_name - fi-FI locale * Fix female_first_name and male_first_name - nb-NO locale * Fix female_first_name and male_first_name - sk locale * Fix female_first_name and male_first_name - sv locale * Add alias to old method locales * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faker::Namehasfemale_first_nameandmale_first_nameand a few locales hadfirst_name_men,masculine_name,first_name_womenandfeminine_namein their .yml files.This PR changes these locales to strive for consistency in the locales. Since we're using the
flexible :namein theFaker::Name, I added aliases to avoid crashes. We're not deprecating these old methods for now.ps: I also added tests for these new locales.