Fallback translation without available locales enforcement #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous spec would fail to cover the new code, and would pass without the changes.
deivid-rodriguez
force-pushed
the
fallback-without-enforcement
branch
2 times, most recently
from
1b00eb9 to
072a169
Compare
vbrazo
changed the title
vbrazo
reviewed
Sep 29, 2018
test/test_locale.rb
Outdated
| I18n.available_locales += [:en] | ||
| end | ||
|
|
||
| def test_with_locale_does_not_fail_if_locale_not_available_in_the_application_and_enforce_available_locales_is_set |
There was a problem hiding this comment.
This is one of the longest name methods that I've ever seen in my life.
There was a problem hiding this comment.
Actually the last part can be removed since what this patch is doing is making this independent of the specific enforce_available_locales setting value! 😄 Let me update it!
deivid-rodriguez
force-pushed
the
fallback-without-enforcement
branch
from
072a169 to
b4bde1b
Compare
deivid-rodriguez
force-pushed
the
fallback-without-enforcement
branch
from
b4bde1b to
f156617
Compare
|
@vbrazo when is this going to be released? |
|
Sorry for the delay. It's near the top of my todo list to make a release. :) |
This was referenced Oct 11, 2018
|
As I commented here I still have the same issue after this patch. |
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
…y#1377) * Fallback translation without available locales enforcing * Available locales can't be edited in place The previous spec would fail to cover the new code, and would pass without the changes. * Add ensures for max safety * Add tests for `with_locale` method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased #1039, removed unrelated stuff, fixed some issues that I found and completed some missing tests.
This PR fixes #1030.