Add Faker::GratefulDead #1315
Merged
Add Faker::GratefulDead #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
reviewed
Jul 20, 2018
test/test_faker_grateful_dead.rb
Outdated
| @@ -0,0 +1,15 @@ | |||
| # frozen_string_literal: truer | |||
There was a problem hiding this comment.
It should be true instead of truer.
There was a problem hiding this comment.
I fixed this issue for you and updated the changelog.
vbrazo
reviewed
Jul 20, 2018
| # frozen_string_literal: true | ||
|
|
||
| require_relative 'test_helper' | ||
|
|
There was a problem hiding this comment.
You should declare a class above the methods.
It should be something like class TestFakerGratefulDead < Test::Unit::TestCase.
There was a problem hiding this comment.
Please fix this and make the tests pass.
There was a problem hiding this comment.
made the fixes and all tests passing. Thank you!
vbrazo
approved these changes
Jul 21, 2018
|
@wileybaba just a heads up: I'm adding a namespace for your GratefulDead in this PR #1401. Since we haven't released this object yet, we don't need to deprecate it. Thanks 👍 |
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* grateful_dread * Update CHANGELOG.md * Update test_faker_grateful_dead.rb * Update test_faker_grateful_dead.rb * added class above methods in Faker::GratefulDead * minor adjustment to yml file margins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added simple functionality to pump out a couple dead tunes and players.