Add some tests #1240
Merged
Add some tests #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
approved these changes
May 22, 2018
| @@ -5,7 +5,7 @@ def setup | |||
| @tester = Faker::Measurement | |||
| end | |||
|
|
|||
| def height | |||
| def test_height | |||
There was a problem hiding this comment.
I like the match and the expression that we pass. There is another way to validate the object type. You could do something like assert Faker::Name.first_name.is_a? String as well.
| array = [1, 2, 3] | ||
| range = 1..10 | ||
| assert array.include?(@tester.send(:resolve, array)) | ||
| assert range.include?(@tester.send(:resolve, range)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for issue #1233 created by @vbrazo
Side note:
I am not sure how to test the
elsecases of random_type and random_complex_type. I would love to hear any ideas you may have.Current coverage