Fixes NL postcode #1197
Merged
Fixes NL postcode #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* An effort was made in 12df44f to account for Netherlands postcodes never including the letters SS, SD, or SA. This let to some odd output, as mentioned in #1188. * The issue, as far as I can tell, is that `Faker#regexify` is built to handle negative lookbehind regexes. * This is a naive solution, but simple hardcodes all the allowed letter combos in. * As for a test case, the previously implemented one as `test_nl_postcode` was actually an intermittent failure (which could be seen by running it a bunch of times in a row). I've kept it as is because I'm not sure how to make it better, short of telling it to execute a ton of times (which seems silly). Open to ideas on that.
|
Looks good to me. There was indeed an intermittent failure. Thanks for the solution 👍 @JonathanWThom |
|
@vbrazo Welcome! |
|
:) |
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* An effort was made in faker-ruby@12df44f to account for Netherlands postcodes never including the letters SS, SD, or SA. This let to some odd output, as mentioned in faker-ruby#1188. * The issue, as far as I can tell, is that `Faker#regexify` is built to handle negative lookbehind regexes. * This is a naive solution, but simple hardcodes all the allowed letter combos in. * As for a test case, the previously implemented one as `test_nl_postcode` was actually an intermittent failure (which could be seen by running it a bunch of times in a row). I've kept it as is because I'm not sure how to make it better, short of telling it to execute a ton of times (which seems silly). Open to ideas on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An effort was made in 12df44f
to account for Netherlands postcodes never including the letters SS, SD,
or SA. This led to some odd output, as mentioned in Faker::Address.postcode #1188.
The issue, as far as I can tell, is that
Faker#regexifynot is built tohandle negative lookbehind regexes. And I'm not really sure how it could.
This is a naive solution, but simply hardcodes all the allowed letter
combos in.
As for a test case, the previously implemented one,
test_nl_postcode,was actually an intermittent failure (which could be seen by running it
a bunch of times in a row). I've kept it as is because I'm not sure how
to make it better, short of telling it to execute a ton of times (which
seems silly). Open to ideas on that.