Update Faker::Number.between docs #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
reviewed
May 12, 2018
doc/number.md
Outdated
| @@ -15,6 +15,7 @@ Faker::Number.normal(50, 3.5) #=> 47.14669604069156 | |||
| # Required parameter: digits | |||
| Faker::Number.hexadecimal(3) #=> "e74" | |||
|
|
|||
| # Boundry numbers are inclusive | |||
There was a problem hiding this comment.
Did you mean Boundary numbers? @SpyMaster356
- include required parameters - fix typo
|
Whoops, thanks for catching that. I've also added documentation for the required params too, as that was missing. |
|
Good job. Thanks 👍🏻 |
vbrazo
changed the title
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add note that Number.between is inclusive * update documentation for Faker::Number.between - include required parameters - fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding a simple note for future doc readers.
When I was looking up the documentation for Number.between I wasn't 100% sure if the boundary numbers were inclusive. Looking at the tests did show that it was.