Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ruby syntax highlighting in Omniauth doc #1128

Merged
merged 1 commit into from
May 18, 2018
Merged

Use ruby syntax highlighting in Omniauth doc #1128

merged 1 commit into from
May 18, 2018

Conversation

swrobel
Copy link
Contributor

@swrobel swrobel commented Jan 23, 2018

No description provided.

@Evan-M
Copy link
Contributor

Evan-M commented Jan 31, 2018 •
edited
Loading

That resolves one of my pet-peeves with this particular Faker lib!
The other is with the inconsistency of the hash-keys in the various responses. (See #913)

@swrobel
Copy link
Contributor Author

swrobel commented May 15, 2018

@vbrazo rebased off latest master!

@vbrazo vbrazo self-requested a review May 15, 2018 21:30
vbrazo
vbrazo requested changes May 18, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the changelog.md and add your PR and GitHub ID?

@swrobel
Copy link
Contributor Author

swrobel commented May 18, 2018 •
edited
Loading

Seriously? It's a minor doc formatting change.

@vbrazo vbrazo merged commit 138a470 into faker-ruby:master May 18, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:40
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@swrobel @vbrazo
Use ruby syntax highlighting in Omniauth doc (faker-ruby#1128)
1b13828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo Awaiting requested review from vbrazo

Assignees

@swrobel swrobel

Labels
📘 Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swrobel @Evan-M @vbrazo