Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tokens to Faker::Stripe #1107

Merged
merged 4 commits into from
May 27, 2018
Merged

Conversation

bhaibel
Copy link
Contributor

@bhaibel bhaibel commented Jan 5, 2018

Add tokens to Faker::Stripe

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could you please rebase with master, fix the Rubocop violations and let me know when it's ready for review again?

@vbrazo vbrazo force-pushed the master branch 4 times, most recently from a359def to a5d7731 Compare May 22, 2018 21:15
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had free time today and made the necessary changes. Now I think the PR looks ok.

Thanks for contributing. I know you're a first-time contributor. Welcome. Thanks for the hard work 🥇

@vbrazo vbrazo merged commit a6d3a63 into faker-ruby:master May 27, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:24
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Add tokens to Faker::Stripe

* Fix rubocop violations

* Update changelog.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants