Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove un-necessary NodePorts from system test. #7608

Closed
see-quick opened this issue Nov 10, 2022 · 0 comments · Fixed by #10384 or #10382
Closed

Remove un-necessary NodePorts from system test. #7608

see-quick opened this issue Nov 10, 2022 · 0 comments · Fixed by #10384 or #10382
Assignees
Milestone

Comments

@see-quick
Copy link
Member

In HttpBridgeKafkaExternalListenersST.java (#7526), we have a test case (i.e., testWeirdUsername), which currently uses NodePort. Fortunately, we can remove it, because it is leftover during the refactoring of test clients by Lukas.

IIRC reason why we are using external producer etc. was that at the time I was writing those "weird username tests", there were no possibilities to use internal clients - as they didn't allow any username to be longer than some number of characters and it shouldn't contain any special characters. External clients are allowing it.

Test cases currently do the following:

  1. Create a bridge consumer to receive messages from the external listener (NodePort)
  2. Create a producer to produce messages via the same listener (NodePort)

But we can easily modify 2. point to use internal listeners instead of NodePort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment