From 5a4ae24e7818672491501b00e622f5f47f6ac429 Mon Sep 17 00:00:00 2001
From: Michael Noah <92764374+mnoah1@users.noreply.github.com>
Date: Tue, 19 Nov 2024 00:11:39 -0500
Subject: [PATCH] Adjust default color and style for spelling error decorations
 (#3799)

---
 package.json                                              | 8 ++++----
 packages/_server/spell-checker-config.schema.json         | 8 ++++----
 .../src/config/cspellConfig/AppearanceSettings.mts        | 4 ++--
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/package.json b/package.json
index 7eb6ec3494..bd50aa39b3 100644
--- a/package.json
+++ b/package.json
@@ -3062,7 +3062,7 @@
                 "type": "string"
               },
               "textDecorationColor": {
-                "default": "#fc4",
+                "default": "#348feb",
                 "markdownDescription": "The decoration color for normal spelling issues.\n\nSee: [text-decoration - CSS: Cascading Style Sheets, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration)\n- color - see: [text-decoration-color, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color)\n\nExamples:\n- `green`\n- `yellow`\n- `#ff0c`",
                 "scope": "application",
                 "since": "4.0.0",
@@ -3151,7 +3151,7 @@
                 "type": "string"
               },
               "textDecorationColor": {
-                "default": "#fc4",
+                "default": "#348feb",
                 "markdownDescription": "The decoration color for normal spelling issues.\n\nSee: [text-decoration - CSS: Cascading Style Sheets, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration)\n- color - see: [text-decoration-color, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color)\n\nExamples:\n- `green`\n- `yellow`\n- `#ff0c`",
                 "scope": "application",
                 "since": "4.0.0",
@@ -3223,7 +3223,7 @@
             "type": "string"
           },
           "cSpell.textDecorationColor": {
-            "default": "#fc4",
+            "default": "#348feb",
             "markdownDescription": "The decoration color for normal spelling issues.\n\nSee: [text-decoration - CSS: Cascading Style Sheets, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration)\n- color - see: [text-decoration-color, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color)\n\nExamples:\n- `green`\n- `yellow`\n- `#ff0c`",
             "scope": "application",
             "since": "4.0.0",
@@ -3277,7 +3277,7 @@
             "type": "string"
           },
           "cSpell.useCustomDecorations": {
-            "default": true,
+            "default": false,
             "markdownDescription": "Draw custom decorations on Spelling Issues.\n- `true` - Use custom decorations.\n- `false` - Use the VS Code Diagnostic Collection to render spelling issues.",
             "scope": "application",
             "since": "4.0.0",
diff --git a/packages/_server/spell-checker-config.schema.json b/packages/_server/spell-checker-config.schema.json
index 0c6d3f1e08..37f921a62e 100644
--- a/packages/_server/spell-checker-config.schema.json
+++ b/packages/_server/spell-checker-config.schema.json
@@ -2651,7 +2651,7 @@
               "type": "string"
             },
             "textDecorationColor": {
-              "default": "#fc4",
+              "default": "#348feb",
               "description": "The decoration color for normal spelling issues.\n\nSee: [text-decoration - CSS: Cascading Style Sheets, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration)\n- color - see: [text-decoration-color, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color)\n\nExamples:\n- `green`\n- `yellow`\n- `#ff0c`",
               "markdownDescription": "The decoration color for normal spelling issues.\n\nSee: [text-decoration - CSS: Cascading Style Sheets, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration)\n- color - see: [text-decoration-color, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color)\n\nExamples:\n- `green`\n- `yellow`\n- `#ff0c`",
               "scope": "application",
@@ -2750,7 +2750,7 @@
               "type": "string"
             },
             "textDecorationColor": {
-              "default": "#fc4",
+              "default": "#348feb",
               "description": "The decoration color for normal spelling issues.\n\nSee: [text-decoration - CSS: Cascading Style Sheets, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration)\n- color - see: [text-decoration-color, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color)\n\nExamples:\n- `green`\n- `yellow`\n- `#ff0c`",
               "markdownDescription": "The decoration color for normal spelling issues.\n\nSee: [text-decoration - CSS: Cascading Style Sheets, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration)\n- color - see: [text-decoration-color, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color)\n\nExamples:\n- `green`\n- `yellow`\n- `#ff0c`",
               "scope": "application",
@@ -2830,7 +2830,7 @@
           "type": "string"
         },
         "cSpell.textDecorationColor": {
-          "default": "#fc4",
+          "default": "#348feb",
           "description": "The decoration color for normal spelling issues.\n\nSee: [text-decoration - CSS: Cascading Style Sheets, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration)\n- color - see: [text-decoration-color, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color)\n\nExamples:\n- `green`\n- `yellow`\n- `#ff0c`",
           "markdownDescription": "The decoration color for normal spelling issues.\n\nSee: [text-decoration - CSS: Cascading Style Sheets, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration)\n- color - see: [text-decoration-color, MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color)\n\nExamples:\n- `green`\n- `yellow`\n- `#ff0c`",
           "scope": "application",
@@ -2890,7 +2890,7 @@
           "type": "string"
         },
         "cSpell.useCustomDecorations": {
-          "default": true,
+          "default": false,
           "description": "Draw custom decorations on Spelling Issues.\n- `true` - Use custom decorations.\n- `false` - Use the VS Code Diagnostic Collection to render spelling issues.",
           "markdownDescription": "Draw custom decorations on Spelling Issues.\n- `true` - Use custom decorations.\n- `false` - Use the VS Code Diagnostic Collection to render spelling issues.",
           "scope": "application",
diff --git a/packages/_server/src/config/cspellConfig/AppearanceSettings.mts b/packages/_server/src/config/cspellConfig/AppearanceSettings.mts
index b246ca59b9..1b24ddb3ec 100644
--- a/packages/_server/src/config/cspellConfig/AppearanceSettings.mts
+++ b/packages/_server/src/config/cspellConfig/AppearanceSettings.mts
@@ -107,7 +107,7 @@ interface Decoration {
      *
      * @scope application
      * @since 4.0.0
-     * @default "#fc4"
+     * @default "#348feb"
      */
     textDecorationColor?: string;
 
@@ -183,7 +183,7 @@ export interface AppearanceSettings extends Appearance {
      *
      * @scope application
      * @since 4.0.0
-     * @default true
+     * @default false
      */
     useCustomDecorations?: boolean;