Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Mention bridge as attribute of highway #5792

Closed
goldfndr opened this issue Aug 6, 2024 · 3 comments
Closed

Feature request: Mention bridge as attribute of highway #5792

goldfndr opened this issue Aug 6, 2024 · 3 comments
Assignees

Comments

@goldfndr
Copy link
Contributor

goldfndr commented Aug 6, 2024

Use case
There are many places where a bridge will overlap another highway at a sharp angle or even coincide with the same angle for a great distance. The rendering of bridges uses rounded caps but, from what I can tell, not for transitions within the bridge (e.g. lane count change). It can be difficult to distinguish which piece of road is a bridge and which is at ground level, especially within a downtown area with limited right of way for expansion.

For example, a motorway bridge overlapping a ground-level motorway.

Proposed Solution
In #1326 / b6d286a a tunnel attribute was added for subject roads; improved in #3870. A bridge attribute could similarly be displayed as appropriate.

@goldfndr goldfndr changed the title Mention bridge as attribute of highway Feature request: Mention bridge as attribute of highway Aug 6, 2024
@Helium314
Copy link
Collaborator

tunnel and location=underground show "underground", do you have a suggestion for a similar location label that could apply to bridges (and possibly location=overhead)?

@goldfndr
Copy link
Contributor Author

goldfndr commented Aug 14, 2024

I took a look through the quests (including SCEE's) and I'm not spotting one in which location=overhead or location=overground or location=roof might apply that didn't already have level; quest objects seem to be at (or, in the case of barriers like turnstiles and gates, at least attached to) ground level, even the height quests are measured from ground. I didn't spot a pipe/cable color/substance/material quest, and a future power pole attachment quest oughtn't need it (but other power attachments might). Closest I saw was possibly SCEE's color quest for a building:part that lacked level but that seems more likely bad tagging. Is a stile ever fully elevated?

So, for now, I'd say something like:

val bridge = tags["bridge"]
 if (bridge != null && bridge != "no") {
     return resources.getString(R.string.bridge)
}

@westnordost westnordost self-assigned this Aug 14, 2024
@westnordost
Copy link
Member

As for the label, I think "on bridge" makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants