Upload scheduled debug builds to Github actions artifacts #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `build:debug` task and the `nwjs`, `release`, `compile` and `dist` tasks now support the trailing `debug` task argument, which will compile the debug build instead of the production build. Example: grunt build:debug dist:linux64:debug This also adds the new `DEVELOPMENT` global var in addition to `DEBUG` and splits some of the logic between those two, as some code is meant to only be run in a development build. Debug builds have the regular debug flags sets, similar to the development build, and the NW.js SDK flavor is used for compiling them, so that the Chromium dev-tools can be accessed.
Run daily, uploaded as build artifacts for win64, osx64 and linux64.
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
==========================================
+ Coverage 88.31% 88.37% +0.06%
==========================================
Files 456 456
Lines 14902 14979 +77
Branches 1313 1317 +4
==========================================
+ Hits 13161 13238 +77
Misses 1657 1657
Partials 84 84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #360
DEBUGglobal var toDEVELOPMENT, adds the newDEBUGglobal var, and splits the logic between them accordingly.build:debugtask alias, which runs tests and creates a debug build viawebpack:debug.:debugcompile flag for thenwjs,compile,releaseanddisttasks.This flag has to be set at the end of the arguments of each task, eg.
dist:archive_win64:archive_osx64:archive_linux64:debug.The debug flag gets passed through to the
nwjstask, where it will use the NW.js SDK flavor instead of the normal flavor, so that the Chromium dev tools become available in the final debug build.The final builds are uploaded as artifacts and can be downloaded from there (requires Github login).
Unfortunately, due to a current restriction of the upload-artifacts action, all files are stored in a nested zip-archive / tarball. There's no workaround for that, as the upload-artifacts action always archives/compresses its inputs. Not building our own archives doesn't work either, as the action doesn't care for file permissions, which would break macOS/Linux builds. Also, our own archives are built deterministically, and this effort shouldn't be ignored or discarded.
TODO: