Ember upgrade #519
Merged
Ember upgrade #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move view:toplevel to template:application and application initializer - Don't let webpack parse Ember and EmberData TODO: - Fix tests
- Fix component attribute bindings and re-rendering issues - Change attribute name "default" to "defaultValue"
- Add common "selectable" component that binds the value attribute to the selection and vice versa - Change name of RadioBtnsComponent to RadioButtonsComponent - Change name of RadioBtnComponent to RadioButtonsItemComponent - Add DropDownSelectionComponent and DropDownListComponent - Set optionValuePath to "id" for both parent components - Update class names - Rewrite tests TODO: - Update templates of all routes/components using the new components - Change component content data to match the common optionValuePath - Fix remaining stylesheets
- Rewrite templates - Fix content data - Fix class names - Rename content data variables in each settings controller 96c0ae5
bastimeyer
force-pushed
the
ember-upgrade
branch
from
8b8d517 to
aa127d9
Compare
- Set ember-data as an NPM dependency (ember-addon) and remove it from bower - Add required ember-data build and runtime dependencies - Upgrade ember-data-model-fragments - Remove the now unnecessary ember-data workaround imports - Add ember-data/version and initializer modules - Add ember-features.json - Strip heimdalljs and disabled features from ember-data and remove debug imports in production build TODO: - Fix warning in model tests - Update all ember-data imports and remove custom global module - Update ember-data-model-fragments imports as well and import its initializer instead of defining a custom one
- Switch ember dependency (bower) to ember-source (npm) - Remove all Bower related files - Update CI config, git ignore file and docs TODO: - Manually build Ember once it's been upgraded to a newer version. Ember-data is already being built manually as an ember addon.
and fix failing tests
2.14.x contained a backburner bug, resulting in failed tests which are using sinon.useFakeTimers()
bastimeyer
force-pushed
the
ember-upgrade
branch
from
b98b8d2 to
4444d5a
Compare
Don't unnecessarily use HotkeyService
So BooleanTransform doesn't need to be imported from a private ED module
and remove custom global ember-data module
record.destroyRecord() seems to have changed between EmberData 2.12 and 2.16 and doesn't remove deleted+saved records from the store anymore. Those records now need to be explicitly unloaded in order to let the store return false from calling store.hasRecordForId(model, id) FollowButtonComponent already unloads records when unfollowing, so even if there are no tests for the unfollow action yet, nothing will break
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/streamlink/streamlink-twitch-gui/projects/5
Current version:
3.0.0Latest version:
3.0.0@ember/xyzimportsember >= 2.16.0https://github.com/ember-cli/ember-rfc176-data
Import source modulesEmber hasn't transitioned to its modular structure yet. Let
babel-plugin-ember-modules-api-polyfilltranslate imports into global lookups until then. 😒🐹embermoduleember-qunitDropDownComponentandRadioButtonsComponentSome components have been rewritten, needs further work to make events behave correctly again. All currently added hotkeys should be working without any issues, though.
Upgrade to latest versionCurrent version:
2.12.2Latest version:
3.0.1Can't upgrade to a more recent version of Ember Data due to several issues regarding deleting, unloading and re-creating records which have been broken since
2.13and are still not fixed in3.0. 😒🐹Ember Data is now an Ember addon and needs to be built from source.
Strip performance instrumentation and beta features.
Strip debug assertions.
ember-datamoduleAttempted to handle event
notFoundon twitchStream:ID while in state root.emptymodel-fragmentsmoduleProduction buildsDebugging methods are being imported correctly in the
3.0release (supporting Ember Data3.0.0) and can be removed then. For now, it's not possible without using more babel plugins, which is not worth the effort.ember-data-localstoragemodule🎉🎉🎉