Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup command is missing --undo-buffer-size flag #49

Closed
anthonyra opened this issue Nov 13, 2023 · 1 comment
Closed

setup command is missing --undo-buffer-size flag #49

anthonyra opened this issue Nov 13, 2023 · 1 comment

Comments

@anthonyra
Copy link

If you run the following command

substreams-sink-sql setup $DSN docs/tutorial/substreams-clickhouse.yaml
new psql loader: driver clickhouse does not support reorg handling. You must use set a non-zero undo-buffer-size

It'll fail since you need to set undo-buffer-size > 0. In change log it recommends 12. But

substreams-sink-sql setup $DSN docs/tutorial/substreams-clickhouse.yaml --undo-buffer-size=12
unknown flag: --undo-buffer-size
@sduchesneau
Copy link
Contributor

nice catch @anthonyra !
Instead of adding the support for that flag, I made the setup aware of the backend capabilities: it will now automatically create the reorg table on postgres, and not try to do so on clickhouse.
The user can still decide if it wants to use the reorg or the undo-buffer when running on postgres, the behavior will be unchanged for clickhouse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants