Ignore any unstructured output from the package managers #3563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keraito
requested review from
Hypnosphi,
ndelangen,
shilman and
stijnkoopal
as code owners
Hypnosphi
added
cli
patch:yes
Hypnosphi
approved these changes
May 9, 2018
Codecov Report
@@ Coverage Diff @@
## master #3563 +/- ##
==========================================
- Coverage 37.12% 37.11% -0.01%
==========================================
Files 509 509
Lines 10848 10849 +1
Branches 977 971 -6
==========================================
Hits 4027 4027
+ Misses 6244 6216 -28
- Partials 577 606 +29
Continue to review full report at Codecov.
|
Hypnosphi
added a commit
that referenced
this pull request
May 17, 2018
Ignore any unstructured output from the package managers
Hypnosphi
added
the
patch:done
This was referenced Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Addresses #3529
What I did
See #3529 (comment) for my understanding of the issue. TLDR: Installation process of storybook gets halted on Windows due to unstructured warning of npm about a
npm update check failedand a warning in the implementation ofyarn.The easiest fix is to just ignore those warnings as they are not the responsibility of Storybook and are not specific to the installation of Storybook, which is what I have done. Another solution would be to print these warnings during the installation (with a special note), potentially under a parameter flag of some kind, to either show or hide it.