#3324 fix double quotes in prop table and add additional examples #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielduan
requested review from
dangreenisrael,
Hypnosphi,
theinterned,
usulpro,
z4o4z and
ndelangen
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3401 +/- ##
==========================================
+ Coverage 36.78% 36.87% +0.08%
==========================================
Files 458 458
Lines 10044 10045 +1
Branches 907 913 +6
==========================================
+ Hits 3695 3704 +9
+ Misses 5818 5782 -36
- Partials 531 559 +28
Continue to review full report at Codecov.
|
danielduan
force-pushed
the
dd/docgen-prop-table
branch
from
cafe14a to
25dd8c1
Compare
|
Netlify seems to have times out, not a blocker I'd say for this PR |
ndelangen
approved these changes
Apr 11, 2018
Hypnosphi
previously requested changes
Apr 11, 2018
danielduan
force-pushed
the
dd/docgen-prop-table
branch
from
b0086de to
3ffeddb
Compare
|
good catch @Hypnosphi, should be fixed now. |
danielduan
dismissed
Hypnosphi’s stale review
fixed the missing quotes in source
Hypnosphi
added
the
patch:yes
Hypnosphi
pushed a commit
that referenced
this pull request
May 17, 2018
#3324 fix double quotes in prop table and add additional examples
Hypnosphi
added
the
patch:done
This was referenced Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: fix #3324
What I did
removed quotes and added examples for default props
How to test
Is this testable with Jest or Chromatic screenshots?
Does this need a new example in the kitchen sink apps?
yes
Does this need an update to the documentation?
Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]