Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prereq yarn install level #2638

Merged
merged 2 commits into from
Jan 4, 2018

Conversation

ChristianDavis
Copy link
Contributor

Yarn 1.0.0 contains a linking bug that is fixed in 1.3.0 (released 1.3.2), creates failures otherwise

yarn revision: https://github.com/yarnpkg/yarn/releases/tag/v1.3.0

Issue:
#2382 (comment)

What I did

How to test

Is this testable with jest or storyshots?

Does this need a new example in the kitchen sink apps?

Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

Yarn 1.0.0 contains a linking bug that is fixed in 1.3.2, creates issues otherwise:
storybookjs#2382 (comment)
@codecov
Copy link

codecov bot commented Jan 4, 2018

Codecov Report

Merging #2638 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2638   +/-   ##
=======================================
  Coverage   34.33%   34.33%           
=======================================
  Files         388      388           
  Lines        8682     8682           
  Branches      897      890    -7     
=======================================
  Hits         2981     2981           
- Misses       5106     5113    +7     
+ Partials      595      588    -7
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
lib/ui/src/modules/ui/index.js 0% <0%> (ø) ⬆️
addons/events/src/components/Event.js 38.55% <0%> (ø) ⬆️
lib/ui/src/libs/withLifecycleDecorator.js 17.14% <0%> (ø) ⬆️
addons/links/src/react/components/link.js 78.78% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Rules.js 0% <0%> (ø) ⬆️
...tive/src/preview/components/StoryListView/index.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 79.31% <0%> (ø) ⬆️
...modules/ui/components/stories_panel/text_filter.js 30.98% <0%> (ø) ⬆️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae4d6a5...641eac5. Read the comment docs.

@Hypnosphi
Copy link
Member

Please update "engines" field in root package.json as well

@Hypnosphi Hypnosphi added the maintenance User-facing maintenance tasks label Jan 4, 2018
@Hypnosphi Hypnosphi merged commit afc322f into storybookjs:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants