Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netlify vue instance #2386

Merged
merged 2 commits into from
Nov 27, 2017
Merged

Fix netlify vue instance #2386

merged 2 commits into from
Nov 27, 2017

Conversation

cheapsteak
Copy link
Member

@cheapsteak cheapsteak commented Nov 27, 2017

Vue example builds keep failing with missing webpack error

edit: I think it's working

@codecov
Copy link

codecov bot commented Nov 27, 2017

Codecov Report

Merging #2386 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2386   +/-   ##
=======================================
  Coverage   19.92%   19.92%           
=======================================
  Files         293      293           
  Lines        6485     6485           
  Branches      761      743   -18     
=======================================
  Hits         1292     1292           
- Misses       4594     4623   +29     
+ Partials      599      570   -29
Impacted Files Coverage Δ
...ponents/left_panel/stories_tree/tree_decorators.js 33.33% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.04% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 41.41% <0%> (ø) ⬆️
addons/a11y/src/A11yManager.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
addons/jest/src/components/PanelTitle.js 0% <0%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcf7667...1c680fa. Read the comment docs.

@cheapsteak cheapsteak changed the title Fix netlify vue instance (WIP, don't merge, PR created to trigger deploy-preview) Fix netlify vue instance Nov 27, 2017
@Hypnosphi Hypnosphi merged commit a6a5f9f into master Nov 27, 2017
@Hypnosphi Hypnosphi deleted the fix-netlify-vue branch November 27, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants