-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds error when storyshots finds no stories #2079
adds error when storyshots finds no stories #2079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally makes sense to me, thanks!
Codecov Report
@@ Coverage Diff @@
## release/3.3 #2079 +/- ##
===============================================
+ Coverage 21.71% 21.72% +<.01%
===============================================
Files 355 355
Lines 7059 7061 +2
Branches 909 910 +1
===============================================
+ Hits 1533 1534 +1
- Misses 4839 4855 +16
+ Partials 687 672 -15
Continue to review full report at Codecov.
|
@ndelangen @shilman technically it's a feature, so should we rebase it on |
This will introduce a breaking build when there wasn't one before. Definitely a 3.3 feature! |
What is the new build failure? A build without any stories will already currently fail due to Jest failing a suite with zero tests. |
@theshortcut ow, right. You're 💯% correct! |
Issue: #1330
What I did
Added an error when storyshots finds no stories. This is makes the test suite failure more obvious than the current failure of no tests being run.
How to test
Modify
.storybook/config.js
to find no stories, or create a new project with a storyshots suite without any stories.Is this testable with jest or storyshots?
no
Does this need a new example in the kitchen sink apps?
no
Does this need an update to the documentation?
no
If your answer is yes to any of these, please make sure to include it in your PR.