Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yarn workspaces on master #1916

Merged
merged 6 commits into from
Sep 30, 2017
Merged

Use yarn workspaces on master #1916

merged 6 commits into from
Sep 30, 2017

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi added the maintenance User-facing maintenance tasks label Sep 29, 2017
@codecov
Copy link

codecov bot commented Sep 29, 2017

Codecov Report

Merging #1916 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1916      +/-   ##
==========================================
- Coverage    21.3%   21.29%   -0.01%     
==========================================
  Files         257      261       +4     
  Lines        5741     5743       +2     
  Branches      687      684       -3     
==========================================
  Hits         1223     1223              
+ Misses       4000     3997       -3     
- Partials      518      523       +5
Impacted Files Coverage Δ
app/react/src/server/index.js 0% <ø> (ø) ⬆️
app/vue/src/server/index.js 0% <ø> (ø) ⬆️
app/react/bin/index.js 0% <ø> (ø)
app/react/bin/build.js 0% <ø> (ø)
app/vue/bin/build.js 0% <ø> (ø)
app/vue/bin/index.js 0% <ø> (ø)
app/vue/src/server/build.js 0% <ø> (ø) ⬆️
app/react/src/server/build.js 0% <ø> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
addons/info/src/components/Node.js 39.7% <0%> (ø) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ecd78a...57fbf45. Read the comment docs.

@ndelangen
Copy link
Member

This is happening on my machine:
screen shot 2017-09-30 at 11 40 37

@ndelangen
Copy link
Member

@Hypnosphi
Copy link
Member Author

Hypnosphi commented Sep 30, 2017

This is happening on my machine

Which yarn version do you have?

UPD: please try again, I just made the command look exactly the same as in release/3.3, so now it should work on any 1.x.x yarn version

@ndelangen
Copy link
Member

screen shot 2017-09-30 at 13 12 32

@ndelangen
Copy link
Member

I can confirm this on my machine now.

I tested bootstrapping everything, cra-kitchen-sink, docs

@ndelangen ndelangen requested a review from a team September 30, 2017 11:26
@Hypnosphi Hypnosphi merged commit 8e84ec8 into master Sep 30, 2017
@Hypnosphi Hypnosphi deleted the yarn-master branch September 30, 2017 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants