Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color cannot use RGBA #802

Closed
shilman opened this issue Apr 15, 2017 · 5 comments
Closed

color cannot use RGBA #802

shilman opened this issue Apr 15, 2017 · 5 comments
Labels
addon: knobs bug help wanted

Comments

@shilman
Copy link
Member

shilman commented Apr 15, 2017

Issue by lifeiscontent
Tuesday Jan 03, 2017 at 10:32 GMT
Originally opened as storybook-eol/storybook-addon-knobs#82

since the color picker has an option to use RGBA, it should be supported as an output value for a knob
@ndelangen
Copy link
Member

Clearly a bug! Do you think you could create a PR? @lifeiscontent

@vgpena
Copy link

vgpena commented Aug 25, 2017

Would the rgba value ideally appear in the URL as a part of the Knobs querystring, in addition to the hex value?

@lifeiscontent
Copy link
Member

@vgpena I'd imagine so if that's how it currently behaves. I'm unsure because I haven't written a story in several months.

@stale stale bot added the inactive label Dec 19, 2017
@ndelangen
Copy link
Member

@vgpena There's a hex notation for rgba, so that shouldn't be a problem.

@Primigenus Primigenus mentioned this issue Jan 2, 2018
Closed
@storybookjs storybookjs deleted a comment from stale bot Jan 2, 2018
@Primigenus Primigenus mentioned this issue Jan 3, 2018
Merged
@Hypnosphi
Copy link
Member

Fix released as 3.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addon: knobs bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@lifeiscontent @shilman @vgpena @danielduan @ndelangen @Hypnosphi @mthuret