Hot reloading breaks with React Native when having multiple storiesOf in a single file

[koenpunt]

Bug or support request summary

Hot reloading breaks with React Native when having multiple storiesOf in a single file.

After reading through previous issues concerning the "Story of "XXX" named "XXX" already exists" error, I found the following comment

The issue can be easily reproduced when storiesOf is called two or more times in a single js file (like in the auto-generated stories). Both calls try to set a dispose callback, but the metro "require" polyfill retains only the last one. Any modifications to that file will lead to the error.

#3348 (comment).

After testing this, it indeed does work when there's only a single storiesOf(.., ..) in a file, but when adding another it breaks.

Steps to reproduce

Have a React Native project with Storybooks set up, and add a new story file containing 2 storiesOf() with different naming, for example:

storiesOf('Tutorial/Steps', module)
  .add('Default', () => {
    return <Steps />;
  });

storiesOf('Tutorial/Steps/Congratulations', module)
  .add('Active', () => {
    return <StepCongratulations />;
  });

Make sure that you have hot reloading enabled, and when editing and saving the story file, the app with give the "Story of "XXX" named "XXX" already exists" error.

Possible solution

What I think could work is if an intermediate method for the dispose method is added, that keeps track of all the callbacks registered, as opposed to Metro bundlers require polyfill, that only retains the last callback.

Please specify which version of Storybook and optionally any affected addons that you're running

• @storybook/react-native 3.4.6
• @storybook/addon-actions 3.4.6
• @storybook/addon-links 3.4.6

Affected platforms

React Native 0.55.3

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[vicentedealencar]

I had the same issue

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[GrafMine]

I had the same issue

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[sregg]

I'm having the same issue, is there any fix?

[igor-dv]

@michaelduminy, does your PR fix this ?

[mikeduminy]

@igor-dv I think so. I never noticed it affect multiple storiesOf calls more than single calls, but the symptom is the same so my guess is the PR fixes this.

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!