Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update React app favicon #2104

Closed
dburles opened this issue Oct 21, 2017 · 4 comments
Closed

Update React app favicon #2104

dburles opened this issue Oct 21, 2017 · 4 comments
Labels
good first issue react

Comments

@dburles
Copy link
Contributor

dburles commented Oct 21, 2017

Should use the new "S" logo
@Hypnosphi
Copy link
Member

Hypnosphi commented Oct 21, 2017 •
edited
Loading

Looks like we take resourses from create-react-app's public directory (which contains, among others, react favicon) on purpose: f7a20a9

The easiest workaround is to remove -s public from your storybook and build-storybook scripts in package.json.

Another issue is, our default favicon itself needs to be updated

Current favicon
current favicon

Storybook v3 icon
v3 logo

Feel free to open a PR on that part. PNG and SVG for new icon images are available in the press repo

@design1online design1online mentioned this issue Oct 23, 2017
Merged
@dburles
Copy link
Contributor Author

dburles commented Oct 23, 2017

Great! to be clear, I was referring to your second point that the current favicon is out of date :)

@andreasvirkus
Copy link

I wouldn't mind taking it if that's alright.

@danielduan
Copy link
Member

danielduan commented Nov 1, 2017 •
edited
Loading

published in 3.2.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue react
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dburles @danielduan @ndelangen @Hypnosphi @andreasvirkus