Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax error import statement on storyshots #1720

Closed
satazor opened this issue Aug 23, 2017 · 2 comments
Closed

Syntax error import statement on storyshots #1720

satazor opened this issue Aug 23, 2017 · 2 comments

Comments

@satazor
Copy link
Contributor

satazor commented Aug 23, 2017 •
edited
Loading

Version 3.2.6 & 3.2.7 both contain a change on the babel presets. More specifically,
it was added babel-preset-env and removed babel-preset-es2015 and babel-preset-es2016.

The issue is that the modules option was set to false but this causes issues when integrating with Jest. It must be NOT set if process.env.NODE_ENV is test. CRA does the same here: https://github.com/facebookincubator/create-react-app/blob/master/packages/babel-preset-react-app/index.js#L73
@satazor satazor mentioned this issue Aug 23, 2017
Merged
@shilman
Copy link
Member

shilman commented Aug 23, 2017

Released in 3.2.8, closing. Please re-open if there's more to do here!

@shilman shilman closed this as completed Aug 23, 2017
@satazor
Copy link
Contributor Author

satazor commented Aug 23, 2017

It's working nicely now. Thanks!

This was referenced Jan 12, 2018
Closed
Closed
This was referenced Jul 27, 2020
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shilman @satazor