-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to disable minification when running build-storybook
?
#164
Comments
Currently there is no way. You need to change the webpack config and remove uglifyjs plugin. |
Okay. It's the production build. So, we need to support the production build too. |
@mnmtanish As far as I can see, custom config is hardcoded to |
@moroshko I checked the code, yes it'll work for both alike. |
@moroshko I also though at first that having 2 files will be easy and straightforward but it can cause some issues. So far we're using custom config from webpack.config.js for both the dev-server and the production builds. If we use separate files, users who need the same custom config for both will have to make a copy of the file. Let's say we try to fix it by falling back to webpack.config.js if webpack.config.prod.js does not exist, it makes the config more ambiguous and some users may not want that to happen. We can fix this for now by adding a configType argument to the config function. I've opened a pull request for this #169 |
@mnmtanish Thanks for #169. I'd just update the docs to reflect the changes. |
@moroshko Where did you update the docs? |
@arunoda I didn't. I suggested @mnmtanish to update the docs as part of #169. |
@moroshko Ah okay. BTW: I did it. |
Thanks @arunoda |
@arunoda sorry to reopen such an old thread but the docs aren't clear on what you need to do to set Can you show an example of how one might set that variable and return it with the config? |
Is there a way not to minify the JS files when running
build-storybook
?The text was updated successfully, but these errors were encountered: