Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LinkWrapper in Button component #36

Closed
kylesuss opened this issue Jun 27, 2019 · 1 comment
Closed

Support LinkWrapper in Button component #36

kylesuss opened this issue Jun 27, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@kylesuss
Copy link
Contributor

Similar to how we support the concept of a LinkWrapper in our Link component, we need the same concept in the Button component.

Sometimes something should visually look like a button but also be a link. We support that right now with the isLink prop on Button, however it does not cover the case where you need to use a special Link component (from Gatsby, Next, React Router, etc.).

We have a less than ideal workaround for this now, which is to put a Button inside of a Link, but the LinkWrapper solution discussed here is more ideal and accessible per #34 .
@kylesuss kylesuss added the enhancement New feature or request label Jun 27, 2019
@kylesuss kylesuss mentioned this issue Jun 27, 2019
Merged
@jsomsanith jsomsanith mentioned this issue Jun 28, 2019
Merged
@jsomsanith
Copy link
Contributor

Done with #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsomsanith @kylesuss