From afbc961b2ffe0ad67bb95cad32254d7982df2b9f Mon Sep 17 00:00:00 2001
From: Oli Evans <oli@protocol.ai>
Date: Tue, 13 Dec 2022 11:07:49 +0000
Subject: [PATCH] feat: upload/remove returns removed item

needed by https://github.com/web3-storage/w3cli/pull/20 to find which shards to also remove when removing an upload

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
---
 packages/upload-client/src/types.ts        | 4 +++-
 packages/upload-client/src/upload.js       | 2 ++
 packages/upload-client/test/upload.test.js | 2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/packages/upload-client/src/types.ts b/packages/upload-client/src/types.ts
index af48b72a7..41a734176 100644
--- a/packages/upload-client/src/types.ts
+++ b/packages/upload-client/src/types.ts
@@ -36,7 +36,7 @@ export interface Service {
   upload: {
     add: ServiceMethod<UploadAdd, UploadAddResponse, never>
     list: ServiceMethod<UploadList, ListResponse<UploadListResult>, never>
-    remove: ServiceMethod<UploadRemove, null, never>
+    remove: ServiceMethod<UploadRemove, UploadRemoveResponse | undefined, never>
   }
 }
 
@@ -51,6 +51,8 @@ export interface UploadAddResponse {
   shards?: CARLink[]
 }
 
+export interface UploadRemoveResponse extends UploadAddResponse {}
+
 export interface ListResponse<R> {
   cursor?: string
   size: number
diff --git a/packages/upload-client/src/upload.js b/packages/upload-client/src/upload.js
index 42c7d663c..113007a0f 100644
--- a/packages/upload-client/src/upload.js
+++ b/packages/upload-client/src/upload.js
@@ -151,4 +151,6 @@ export async function remove(
       cause: result,
     })
   }
+
+  return result
 }
diff --git a/packages/upload-client/test/upload.test.js b/packages/upload-client/test/upload.test.js
index 2ff27dd30..4290d84df 100644
--- a/packages/upload-client/test/upload.test.js
+++ b/packages/upload-client/test/upload.test.js
@@ -367,7 +367,7 @@ describe('Upload.remove', () => {
           assert.equal(invCap.can, UploadCapabilities.remove.can)
           assert.equal(invCap.with, space.did())
           assert.equal(String(invCap.nb?.root), car.roots[0].toString())
-          return null
+          return { root: car.roots[0] }
         }),
       },
     })