feat: validate attestation from another service #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
changed the title
hannahhoward
approved these changes
Feb 13, 2025
Merged
volmedo
added a commit
to storacha/go-ucanto
that referenced
this pull request
Feb 25, 2025
Part of #35 This PR ports the changes added to the JS ucanto library here: storacha/ucanto#369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #268
Specifically, we are changing the
did:web:web3.storageservice DID todid:web:up.storacha.networkand want to allow attestations issued bydid:web:web3.storageto still be considered valid.resolves #268
closes #267