feat: Use Indexing Service when feature flag is present #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peeja
changed the title
alanshaw
requested changes
Nov 27, 2024
scripts/delegate-serve.js
Outdated
| * @returns {str is Ucanto.DID<Method>} | ||
| */ | ||
| const isDID = (str, method) => | ||
| str.startsWith(`did:${method ? `${method}:` : ''}`) |
There was a problem hiding this comment.
You could use ucanto schema for this.
import { Schema } from '@ucanto/core'
Schema.did({ method }).is(str)There was a problem hiding this comment.
Aha! I couldn't figure out how to get that to work before. Not sure what wasn't clicking, but it all makes sense now. Pushed as Use Ucanto Schema.
src/util.js
Outdated
| ok: { | ||
| ...locateResult.ok, | ||
| site: locateResult.ok.site.filter( | ||
| (site) => site.space && spaces.includes(site.space) |
There was a problem hiding this comment.
The space should be passed to the locator and used in the query to indexing service.
There was a problem hiding this comment.
Whoops, I forgot to switch this one to the new locator.scopeToSpaces(). Pushed!
| } | ||
| } | ||
| } | ||
| ? spaceScopedLocator(ctx.locator, [stubSpace]) |
There was a problem hiding this comment.
A Space given as a stub (stub_space).
There was a problem hiding this comment.
Exactly—that's what this middleware is for.
package.json
Outdated
| @@ -51,17 +52,18 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@cloudflare/workers-types": "^4.20231218.0", | |||
| "@storacha/cli": "^1.0.1", | |||
| "@storacha/client": "file:../upload-service/packages/w3up-client", | |||
Peeja
force-pushed
the
indexing-service
branch
from
234d125 to
c5fa39d
Compare
Depending on how tests are run, the exception inside the promise can blow things up. We intentionally want to ignore the error here, and just test that it doesn't interfere with serving the data.
alanshaw
approved these changes
Dec 3, 2024
Peeja
force-pushed
the
indexing-service
branch
from
eb4adfb to
6a8d430
Compare
fforbeck
pushed a commit
that referenced
this pull request
Dec 19, 2024
🤖 I have created a release *beep* *boop* --- ## [2.22.0](v2.21.0...v2.22.0) (2024-12-19) ### Features * egress client - ucanto integration ([#123](#123)) ([22bed68](22bed68)) * enable egress tracking in production env ([#135](#135)) ([ad43b62](ad43b62)) * **indexer:** probabilistic feature flag ([#136](#136)) ([dca2b35](dca2b35)) * ucan invocation handler ([#133](#133)) ([b199bfa](b199bfa)) * Use Indexing Service when feature flag is present ([#132](#132)) ([fa3f480](fa3f480)) ### Bug Fixes * **config:** staging kv bidding ([#134](#134)) ([7a523d5](7a523d5)) * **egress-client:** set nonce, expire and fix servedAt ([#130](#130)) ([b135643](b135643)) * enable open telemetry for all envs ([#131](#131)) ([c822465](c822465)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storacha/project-tracking#140
Depends on storacha/blob-fetcher#19 and storacha/upload-service#57
When
ff=indexing-serviceis given in the gateway URL, Freeway will use the Indexing Service to locate blobs.