Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): add callbacks to components, tweak callback structure #138

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

chohmann
Copy link
Contributor

Motivation and Context

#17287

Description

  • updates types to support callbacks in components and that they can be references

How Has This Been Tested?

  • yalc'd into http-spec and then into platform-internal, and those tests are passing

Screenshot(s)/recordings(s)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@chohmann chohmann requested a review from EdVinyard July 21, 2023 16:50
Copy link
Contributor

@EdVinyard EdVinyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed via Zoom

@chohmann chohmann merged commit 90ea9f1 into master Jul 21, 2023
@chohmann chohmann deleted the feat/17287-callbacks-in-components branch July 21, 2023 17:04
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 13.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants