Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support for editorconfig max_line_length #55

Open
mmorearty opened this issue Nov 20, 2017 · 3 comments
Open

Feature request: support for editorconfig max_line_length #55

mmorearty opened this issue Nov 20, 2017 · 3 comments

Comments

@mmorearty
Copy link

As described here, editorconfig supports max_line_length. It would be nice if Reflow had the ability to use that to determine max line length.

@stkb
Copy link
Owner

stkb commented Nov 24, 2017

Hi, sorry I didn't get a notification for this, for whatever reason.

Yes that should be possible. Are you using the VSCode or the Visual Studio version?

@mmorearty
Copy link
Author

I’m on the VSCode version.

@stkb
Copy link
Owner

stkb commented Nov 25, 2017

Thanks. The reason I ask is because I wonder whether it would be better to ask for an extra feature from the editorConfig extension that takes the max_line_length value and creates an editor.rulers setting in the workspace settings.json file. The ruler would then be a helpful guide in the editor and Rewrap can already use rulers anyway.

I see there was a already an issue in editorconfig/editorconfig-vscode#53 but although the editor.rulers solution was mentioned there it wasn't really discussed; it was mostly about soft-wrapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants