Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Droid] Border thickness doesn't seem to match up with iOS #4

Closed
sthewissen opened this issue Feb 14, 2019 · 2 comments · Fixed by #5
Closed

[Droid] Border thickness doesn't seem to match up with iOS #4

sthewissen opened this issue Feb 14, 2019 · 2 comments · Fixed by #5
Labels
help wanted Extra attention is needed up for grabs Available for someone who feels like implementing it

Comments

@sthewissen
Copy link
Owner

The same border thickness value on both platforms gives us a very different looking border. It looks like the Android border is drawn on the outside or on the edge of the control, whereas the one on iOS is drawn on the inside. Might need to figure out a way to draw the Android one on the inside too.

iOS:
image

Droid:

@sthewissen sthewissen added help wanted Extra attention is needed up for grabs Available for someone who feels like implementing it labels Feb 14, 2019
@Miiite
Copy link
Contributor

Miiite commented Feb 14, 2019

When drawing the outline on Android, BorderThickness is used "as is", and not converted into pixels (based on the screen's dp), is there a reason to that ?

if the border thickness used is actually

var borderThickness = _convertToPixels(_pancake.BorderThickness);

Then the result is slightly closer to iOS value (but cornerRadius are misplaced)

screenshot 2019-02-14 at 16 04 19

@sthewissen
Copy link
Owner Author

sthewissen commented Feb 14, 2019

The main reason for that is that I'm more of an iOS minded developer than an Android guy 😂 So yeah, perhaps some more convertToPixels magic could fix this one. I guess that should also be applied elsewhere when it comes to drawing the background to match it all up with the border again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed up for grabs Available for someone who feels like implementing it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants