Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest merger failed - allowBackup tag duplicated #60

Closed
lwasylkowski opened this issue Jul 13, 2017 · 1 comment
Closed

Manifest merger failed - allowBackup tag duplicated #60

lwasylkowski opened this issue Jul 13, 2017 · 1 comment

Comments

@lwasylkowski
Copy link

lwasylkowski commented Jul 13, 2017

Seems like the library project's manifest includes allowBackup and supportsRtl application attributes. I don't think these are necessary, since it's application's role to define whether it supports RTL/backup.

Right now the presence of these attributes is problematic, since if the consumer of the library explicitly sets allowBackup=false in their app's Manifest, the manifest merger complains about duplicate element, forcing the developer to use <tools:replace="android:allowBackup">

I'm happy to submit a pull request if what I say makes sense to you

@hbmartin
Copy link
Contributor

Agreed - the tag is auto-generated when creating new libraries in Android Studio, but I can't think of any reason why it needs to be here.
#61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants