Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more flexibility in the required number of hours per student #55

Open
schmave opened this issue Oct 4, 2017 · 9 comments
Open
Assignees

Comments

@schmave
Copy link
Contributor

schmave commented Oct 4, 2017

Make a user-configurable per-school or per-class default, too.

@schmave
Copy link
Contributor Author

schmave commented Oct 4, 2017

As part of this, the color coding in the student report should also be configurable.

@steveshogren
Copy link
Owner

I'm in progress on this, it should be a couple more days at least.

@steveshogren steveshogren self-assigned this Oct 5, 2017
@steveshogren
Copy link
Owner

So previously, the school wanted the ability to have a student with a required minutes of 300 before age 12, then 330 after that. I stored the date of that "age change" so previous reports would still function correctly. I suppose I'll do the same thing, but now make a new table for the "student minute + date started that requirement".

@schmave
Copy link
Contributor Author

schmave commented Oct 5, 2017

Ah interesting. Yes, they don't seem to have any age-based requirement anymore. I know that TRVS does have one (or used to), so it might still be useful for them.

@steveshogren
Copy link
Owner

I'm not sure the color coding on the student report, did that mean on the student's page, or the sign in page?

@schmave
Copy link
Contributor Author

schmave commented Oct 24, 2017

The thing I was talking about was the student's page where it shows the last few months of attendance and each day is colored in. I think that making the colors configurable per-school (not per-student) would be sufficient.

@steveshogren
Copy link
Owner

Do they want to change the colors, the ranges, or both? Both were messed up and I just fixed them, now they are red = absent, yellow = attended but short, light green = 15 minutes or less short, and green is attended sufficiently. Before it was confusing.

If they want to change the colors and ranges, that is enough of a pain to wrap that into another feature and do it separately, and work on something smaller first.

@schmave
Copy link
Contributor Author

schmave commented Nov 6, 2017

I think that they just want to change the ranges. The one request about color was that you can't tell the difference between a short day (yellow) and an excused absence. Here's what they said:

  • darkest green = 345 minutes or more
  • green = 330 - 344 minutes
  • light green = 300 - 329 minutes
  • yellow = 210 - 299 minutes
  • red = 209 minutes and down
  • once an absence is marked excused, we would like the color in calendar view to change to orange (instead of yellow).

@schmave
Copy link
Contributor Author

schmave commented Jan 23, 2018

Hey Steve! I made a change to make these PFS-requested colors the default for everyone. Would still be great to be able to modify them per-school, but hard-coding it worked for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants