Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template tag 'overextends' no longer works in Django 2.2, as the 'load_template_source' method has been removed #1974

Closed
molokov opened this issue Jan 3, 2021 · 3 comments

Comments

@molokov
Copy link
Contributor

molokov commented Jan 3, 2021

Mezzanine provides the 'overextends' template tag. However, the code for this uses the method 'load_template_source' which was removed in Django 2.0
(See https://docs.djangoproject.com/en/1.11/_modules/django/template/loaders/base/#Loader
vs
https://docs.djangoproject.com/en/2.2/_modules/django/template/loaders/base/#Loader
)

It would be nice if this tag could be fixed for the Django 2.2 version of Mezzanine.

@molokov
Copy link
Contributor Author

molokov commented Jan 3, 2021

... although now I see this warning, so maybe this isn't important, and we should just remove overextends:

if DJANGO_VERSION >= (1, 9):
    warnings.warn(
        "The `overextends` template tag is deprecated in favour of "
        "Django's built-in `extends` tag, which supports recursive "
        "extension in Django 1.9 and above.",
        DeprecationWarning,
        stacklevel=2,
    )

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 5.0.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant