Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PDF generation dependency #180

Closed
molokov opened this issue Feb 28, 2014 · 1 comment
Closed

Upgrade PDF generation dependency #180

molokov opened this issue Feb 28, 2014 · 1 comment
Labels

Comments

@molokov
Copy link
Contributor

molokov commented Feb 28, 2014

pisa 3.0.33 is no longer supported as an independent package, and has been incorporated into xhtml2pdf. (See http://xhtml2pdf.com)

pisa 3.0.33 is dependent on reportlab >= 2.2 and the latest reportlab (as of Feb 2014) is 3.0. But pisa's version checking is broken and doesn't recognise reportlab 3.0 as greater than 2.2

We can make cartridge (and thus pisa) depend on reportlab 2.7, but this version will not work with Python 3.x, so it may be a good idea to update cartridge's PDF generation to depend on xhtml2pdf instead of pisa.

See https://groups.google.com/forum/#!topic/mezzanine-users/d7FKjlUL9ew
and #174 for some discussion.

@stephenmcd
Copy link
Owner

I've made the updates to use xhtml2pdf - just an import change really.

I've also made it so that if it's unusable (as per Python 3 right now), we just hide the pdf invoice button - once it becomes useable, that should just start working.

Repository owner deleted a comment from github-actions bot Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants