Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barrel + exportCommonSymbols + NestJS import conflict #580

Closed
arustamyansv opened this issue Jun 1, 2022 · 1 comment
Closed

Barrel + exportCommonSymbols + NestJS import conflict #580

arustamyansv opened this issue Jun 1, 2022 · 1 comment

Comments

@arustamyansv
Copy link

arustamyansv commented Jun 1, 2022

Hello,

I have the following file structure for proto files
/VENDOR/MICROSERVICE/MODULE/VERSION/*.proto

Here is a list of proto files for CRUDL

entity.proto
create.proto
update.proto
delete.proto
list.proto
get.proto
service.proto

And as a result, I'd love to have a barrel or something similar assembled to have a single import point.

I'm utilizing NestJS as a framework for microservice so there is *_PACKAGE_NAME generated in each file.
As a result, barrel fails cause of conflicts.

So the question is - by any chance is it possible to get *_PACKAGE_NAME only inside the file service is defined?

If not and it looks like it's not, do you think it's a good idea to add?
Or probably just add barrel generation from within the ts-proto?

@stephenh
Copy link
Owner

stephenh commented Jun 5, 2022

Hi @arustamyansv , yeah that makes sense, we have an existing issue #212 that tracks this ask, but haven't had anyone put together a PR yet. Thanks!

@stephenh stephenh closed this as completed Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants