bug: mock-doc Node.contains is not inclusive

[kevinleedrum]

Prerequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Stencil Version

2.10.0

Current Behavior

In unit tests, myNode.contains(myNode) is returning false.

Expected Behavior

myNode.contains(myNode) should return true.

Steps to Reproduce

Create a simple unit test like this:

const el = document.createElement('div');
expect(el.contains(el)).toBe(true);

The test will fail, but it should pass. The spec says that the passed node should be checked against "inclusive descendants". The "inclusive" part means that it should include the object (the parent node) itself when comparing.

You can see the correct behavior in the console:

Code Reproduction URL

https://codesandbox.io/s/stencil-mock-node-contains-test-kcwn2?file=/src/nodeContains.spec.ts

Additional Information

I can probably submit a PR for this shortly. I don't see any tests for the mock Node implementation, by the way, or I would update the test.

[rwaskiewicz]

This fix has been included in the v2.12.0 release. I'm going to close this issue, however if the problem reappears, please feel free to open a new issue!