From af5bfd74f15f3388a9f4028ffc32e58ba892038a Mon Sep 17 00:00:00 2001 From: Alice Date: Wed, 27 Jul 2022 08:58:56 -0400 Subject: [PATCH] chore(cli): remove sys param from `parseFlags` (#3489) This removes the `sys` parameter from the `parseFlags` function in `src/cli/parse-flags.ts`. This parameter was more or less deprecated in #3486 but was not removed at the time because `parseFlags` is part of Stencil's public API, so we need to wait for a major version change to change the type signature of the function. STENCIL-509: remove _sys param from cli/parse_flags.ts::parseFlags --- src/cli/parse-flags.ts | 4 +--- src/cli/public.ts | 5 ++--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/cli/parse-flags.ts b/src/cli/parse-flags.ts index 7600ce4284ff..4562eb5b0c93 100644 --- a/src/cli/parse-flags.ts +++ b/src/cli/parse-flags.ts @@ -18,11 +18,9 @@ import { * Parse command line arguments into a structured `ConfigFlags` object * * @param args an array of CLI flags - * @param _sys an optional compiler system * @returns a structured ConfigFlags object */ -export const parseFlags = (args: string[], _sys?: CompilerSystem): ConfigFlags => { - // TODO(STENCIL-509): remove the _sys parameter here ^^ (for v3) +export const parseFlags = (args: string[]): ConfigFlags => { const flags: ConfigFlags = createConfigFlags(); // cmd line has more priority over npm scripts cmd diff --git a/src/cli/public.ts b/src/cli/public.ts index 272839d6d4cb..3b3bb92394db 100644 --- a/src/cli/public.ts +++ b/src/cli/public.ts @@ -19,7 +19,6 @@ export declare function run(init: CliInitOptions): Promise; */ export declare function runTask(coreCompiler: any, config: Config, task: TaskCommand): Promise; -// TODO(STENCIL-509): remove the _sys parameter here (for v3) -export declare function parseFlags(args: string[], _sys?: CompilerSystem): ConfigFlags; +export declare function parseFlags(args: string[]): ConfigFlags; -export { CompilerSystem, Config, ConfigFlags, Logger, TaskCommand }; +export { Config, ConfigFlags, Logger, TaskCommand };