Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

Decode XDR structures wherever possible. #128

Closed
6 tasks done
Shaptic opened this issue Aug 14, 2023 · 0 comments · Fixed by #157
Closed
6 tasks done

Decode XDR structures wherever possible. #128

Shaptic opened this issue Aug 14, 2023 · 0 comments · Fixed by #157

Comments

@Shaptic
Copy link
Contributor

Shaptic commented Aug 14, 2023

Is your feature request related to a problem? Please describe.
It's annoying to decode base64-encoded XDR that comes from the raw JSON responses because:

(a) you don't necessarily know what the type is without referencing the documentation
(b) you need to actually write the decoding code and error-check it

Describe the solution you'd like
This should be part of Servers request methods: they should wrap and decode the raw responses wherever possible:

  • simulateTransaction
  • getTransaction
  • sendTransaction
  • getLedgerEntries
  • getLatestLedger
  • getEvents

Additional context
The work for this has been started in #127 and #129.

Please 👍 or 👎 as feedback for continuing this feature!

@Shaptic Shaptic moved this from Backlog to Next Sprint Proposal in Platform Scrum Aug 14, 2023
@sydneynotthecity sydneynotthecity moved this from Next Sprint Proposal to Current Sprint in Platform Scrum Aug 15, 2023
@Shaptic Shaptic self-assigned this Aug 16, 2023
@Shaptic Shaptic moved this from Current Sprint to In Progress in Platform Scrum Aug 16, 2023
@Shaptic Shaptic moved this from In Progress to Next Sprint Proposal in Platform Scrum Aug 24, 2023
@Shaptic Shaptic added this to the Soroban Stable P20 Release milestone Oct 2, 2023
@Shaptic Shaptic moved this from Next Sprint Proposal to In Progress in Platform Scrum Oct 6, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Platform Scrum Oct 9, 2023
@Shaptic Shaptic mentioned this issue Oct 9, 2023
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants