-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storeConfigInMeta
option.
#2298
Conversation
ce49ff3
to
7a61ae0
Compare
Allows opting out of using `<meta>` tag in `head` section for configuration. * If set to `true` the calculated config will be stored in a `<meta>` tag in `index.html`. * If set to `false` the calculated config will be stored in the final `my-app-name.js` file. Defaults to `true`.
7a61ae0
to
9867b31
Compare
Add `storeConfigInMeta` option.
Awesome! |
This is indeed what we need. We don't use the generated |
@rwjblue Good work. Should this be documented on the ember-cli site? There are and continue to be a lot of flexible options added that are only visible if looking at ember-app.js file, which is fine for folks who follow the repo but not so much new comers. I volunteer to update the docs and only need to know what should and shouldn't be updated based on ratified solutions. Thanks again. |
How about setting the default to false? Perhaps you can enlighten me but I don't see why you'd want it in index.html instead of the final .js file. |
Equality between builds where only the config changes. Allows staging and production builds to be easily compared. This also enables sharing the same cdn, and just relying on fingerprinting to differentiate, until a staging build is promoted to prod. |
Also I found that in development when running ember server, navigating to |
Yes. We plan to address that with the packager work |
Awesome! I know I'm late to the party, but this PR keeps giving :) |
Allows opting out of using
<meta>
tag inhead
section for configuration.true
the calculated config will be stored in a<meta>
tag inindex.html
.false
the calculated config will be stored in the finalmy-app-name.js
file.Defaults to
true
.Closes #2184.