Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement {{content-for 'head'}}. #2153

Merged
merged 1 commit into from
Oct 1, 2014

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Sep 30, 2014

Closes #2118.

match: /\{\{APP_CONFIG\}\}/g,
replacement: calculateAppConfig
}, {
match: /\{\{CONFIG_META\}\}/g,
replacement: calculateConfigMeta
match: /\{\{content-for '(.+)'\}\}/g,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

([^)]+) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just thinking we would grab everything inside the quotes (but I think I should allow double or single quotes so I'll update that).

@stefanpenner
Copy link
Contributor

nice

@rwjblue rwjblue force-pushed the implement-content-for branch 2 times, most recently from 04119f6 to d75b721 Compare October 1, 2014 03:22
@rwjblue rwjblue force-pushed the implement-content-for branch from d75b721 to a2909a3 Compare October 1, 2014 03:28
@rwjblue rwjblue changed the title [WIP] Implement {{content-for 'head'}}. Implement {{content-for 'head'}}. Oct 1, 2014
rwjblue added a commit that referenced this pull request Oct 1, 2014
@rwjblue rwjblue merged commit 74755d3 into ember-cli:master Oct 1, 2014
@rwjblue rwjblue deleted the implement-content-for branch October 1, 2014 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

content_for-style templating for add-ons to add to index.html
3 participants