Use configstore for storing versionCheck information, and only store the timestamp when the version is checked from npm #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍
|
…the timestamp when the version is checked from npm Add CHANGELOG entry and tests for UpdateChecker/make UpdateChecker more easily mockable
|
@stefanpenner added changelog entry and tests. Had to move some UpdateChecker functionality around to make it more easily testable, but should be working fine. |
stefanpenner
added a commit
that referenced
this pull request
Jul 9, 2014
…orage Use configstore for storing versionCheck information, and only store the timestamp when the version is checked from npm
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1223, using configstore instead of yam for storing
lastVersionCheckandnewestVersionfor the UpdateChecker.