-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More informative error if expected port is not available for ember serve #1306
Comments
I think that we can handle this via configstore, which we already include and use. Basically, we could increment a port number count or something and just handle this properly. We could also trap the |
@rjackson I'd be happy with the second solution. I could see some potential issues with auto incrementing the port number, for example:
If my experience in software has taught me anything, giving users quality information on error is infinitely more valuable than a canned constant. |
I don't think incrementing is correct, rather we should provide "what port" we are trying to bind to in the error message, people can then resolve the issue themselves. I can't believe the default error doesn't just provide this info. |
To me
I am posting this copy as an example of what I consider a good error message, it tells the user:
|
@awildeep yes, I agree. Annoyingly this error is from node, we will have to catch check and rethrow a new one to improve this issue. This is worth it, although I wont have time anytime soon. |
i believe @gavacho & friends are looking into this. |
Merged: #1309 |
That was a quick patch. Thanks @gavacho & friends! |
This is a wish list item, and more for making user experience more pleasant.
I saw someone run into this during their recorded talk at Wicked Good Ember, and I have hit this myself. It usually costs me a few minutes of time before I figure out why it fails, but when I do I always wish the error reported back was more intelligent.
To recreate:
ember serve
ember serve
and receive the cryptic message as follows:Of course after knowing that this problem exists (obviously I can't run two servers on the same port), the error string '... Uhoh. Got error listen EADDRINUSE ...' seems very undescriptive. Perhaps it would be useful to tell the user that the port/address they requested to run the server as is unavailable. And give them some possible solutions such as stopping other
ember serve
processes, or changing the port using the---port
toggle.Again, this is a low priority, but a quality of life improvement as I see it.
The text was updated successfully, but these errors were encountered: