Skip to content

Commit 2aede42

Browse files
author
Michael Vandeberg
committed
Update comment for active ignored request timeout #1660
1 parent f5df8a3 commit 2aede42

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

libraries/net/node.cpp

+3-7
Original file line numberDiff line numberDiff line change
@@ -1361,17 +1361,13 @@ namespace graphene { namespace net { namespace detail {
13611361
uint32_t active_disconnect_timeout = 10 * _recent_block_interval_in_seconds;
13621362
uint32_t active_send_keepalive_timeout = active_disconnect_timeout / 2;
13631363

1364-
// set the ignored request time out to 1 second. When we request a block
1364+
// set the ignored request time out to 6 second. When we request a block
13651365
// or transaction from a peer, this timeout determines how long we wait for them
13661366
// to reply before we give up and ask another peer for the item.
13671367
// Ideally this should be significantly shorter than the block interval, because
13681368
// we'd like to realize the block isn't coming and fetch it from a different
1369-
// peer before the next block comes in. At the current target of 3 second blocks,
1370-
// 1 second seems reasonable. When we get closer to our eventual target of 1 second
1371-
// blocks, this will need to be re-evaluated (i.e., can we set the timeout to 500ms
1372-
// and still handle normal network & processing delays without excessive disconnects)
1373-
1374-
// Increased to 6 in #1660 due to heavy load. May need to adjust further
1369+
// peer before the next block comes in.
1370+
// Increased to 6 from 1 in #1660 due to heavy load. May need to adjust further
13751371
fc::microseconds active_ignored_request_timeout = fc::seconds(6);
13761372

13771373
fc::time_point active_disconnect_threshold = fc::time_point::now() - fc::seconds(active_disconnect_timeout);

0 commit comments

Comments
 (0)